Re-enable audience validation #808
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request re-enables audience validation for token handling in the authentication configuration.
- Removes the explicit disabling of audience validation.
- Restores default behavior for token audience checks.
Comments suppressed due to low confidence (1)
src/eShop.ServiceDefaults/AuthenticationExtensions.cs:47
- Ensure that token validation tests now include scenarios for audience validation to verify that tokens with an incorrect or missing audience are properly rejected.
options.TokenValidationParameters.ValidateAudience = false;
halter73
approved these changes
Mar 31, 2025
Member
|
LGTM, but did ancient github history help? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why this was disabled in the first place...
This pull request includes a small change to AuthenticationExtensions.cs to remove the line that disables audience validation in token validation parameters.
@halter73