Fix HasJsonPropertyName for complex JSON properties #37018
Closed
+81
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The query implementation was correct. You'd need to change the Metadata to store and retrieve the annotation value from the type instead of the property to be consistent with owned types |
Copilot AI
added a commit
that referenced
this pull request
Oct 23, 2025
- Updated RelationalComplexPropertyExtensions to delegate Get/SetJsonPropertyName to ComplexType - Updated RelationalTypeBaseExtensions.GetJsonPropertyName to return null for root JSON types (those with ContainerColumnName) - Updated query pipeline files to call GetJsonPropertyName on complex property instead of complex type - Added assertion in ComplexCollection_can_have_nested_complex_properties_mapped_to_json test - Added HasJsonPropertyName test from PR #37018 Co-authored-by: AndriySvyryd <[email protected]>
|
Superceded by #37019 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37009