-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use just-built packages in the AI chat template by default #6096
Conversation
src/ProjectTemplates/GenerateTemplateContent/GenerateTemplateContent.csproj
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MackinnonBuck I merged from main, including the snapshot tests, and tried to work through getting everything green again. I've hit a couple of snags that we'll have to figure out though.
- The snapshot is specific to whether we're using the pinned version or the just-built version, with the
NuGet.config
andDirectory.Build.Targets
files either included or excluded. - The snapshot bakes in the just-built version number, which is different between local development and CI.
- Question: Is there something in place already where for the official build pipeline we would be able to toggle which mode to build with, or would we just update the targets file to toggle which is the default based on the next release's approach?
To get around the snapshot issues in CI and since we expect our next template release to use the MEAI and Sqlite packages released earlier this week, I swapped it to use the pinned versions by default, and I updated to the versions released this week. This got tests passing locally and in CI.
I hope you don't mind I pushed those changes on into your branch. Feel free to rewind the history and force-push if you want to discard my commits.
...plates/src/ChatWithCustomData/ChatWithCustomData.Web-CSharp/Components/Pages/Chat/Chat.razor
Outdated
Show resolved
Hide resolved
...plates/src/ChatWithCustomData/ChatWithCustomData.Web-CSharp/Components/Pages/Chat/Chat.razor
Outdated
Show resolved
Hide resolved
Thanks for adding those updates, @jeffhandley!
Ideally the snapshot would ignore files that don't get included in the actual
Yeah, also unfortunate. If we did my suggestion above, maybe the tests could build
If the official build pipeline allows us to customize the build command on the fly, we could specify |
...tegrationTests/Snapshots/aichatweb.Basic.verified/aichatweb/Components/Pages/Chat/Chat.razor
Outdated
Show resolved
Hide resolved
…ationTests/Snapshots/aichatweb.Basic.verified/aichatweb/Components/Pages/Chat/Chat.razor Co-authored-by: Jeff Handley <[email protected]>
...ojectTemplates/Microsoft.Extensions.AI.Templates.IntegrationTests/AichatwebTemplatesTests.cs
Outdated
Show resolved
Hide resolved
...ojectTemplates/Microsoft.Extensions.AI.Templates.IntegrationTests/AichatwebTemplatesTests.cs
Show resolved
Hide resolved
…ub.com/dotnet/extensions into mbuck/chat-template-build-improvements
Updates:
|
I think this discussion directly relates and is the cause of #6128. Can you help me understand why the versions are different between local development and CI - or more specifically between the public and the internal CI? |
@RussKie, the reason is because the version suffix when building locally is We could probably update the test to also scrub versions matching that suffix as well. Or we could do something possibly more robust and find the exact |
This PR makes the following changes to the chat template:
Microsoft.EntityFrameworkCore.Sqlite
version defined inVersions.props
instead of being hard-codedMicrosoft Reviewers: Open in CodeFlow