Skip to content

Conversation

MackinnonBuck
Copy link
Member

@MackinnonBuck MackinnonBuck commented Mar 13, 2025

Adds an Aspire option to the AI Chat Web template.

All the existing AI service providers and vector databases are supported, and a new Qdrant option is now enabled when using Aspire.

Fixes #6052

Microsoft Reviewers: Open in CodeFlow

@github-actions github-actions bot added the area-ai-templates Microsoft.Extensions.AI.Templates label Mar 13, 2025
@dotnet-policy-service dotnet-policy-service bot added the waiting-author-feedback 📭 The author of this issue needs to respond in order for us to continue investigating this issue. label Mar 14, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback 📭 The author of this issue needs to respond in order for us to continue investigating this issue. label Mar 17, 2025
@MackinnonBuck
Copy link
Member Author

MackinnonBuck commented Mar 18, 2025

I'm going to undraft this PR so it can get some eyes. Note that there are some known issues I still need to address:

  • When the Aspire option is not used, the generated project still has a .Web suffix. That should probably not be the case.
    Update: Done.
  • New tests need to be added for Aspire variation(s) of the template.
    Update: Done.
  • AI service provider configuration should be moved to the AppHost project.
    Update: Done.
  • The README needs to be updated.
    Update: Done.

@MackinnonBuck MackinnonBuck marked this pull request as ready for review March 18, 2025 05:06
@MackinnonBuck MackinnonBuck requested review from a team as code owners March 18, 2025 05:06
@RussKie RussKie dismissed their stale review March 18, 2025 10:21

No longer relevant

Copy link
Member

@jeffhandley jeffhandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't done any testing; I've just reviewed, but this is looking really good, @MackinnonBuck.

I noted we have 2 places where we're depending on recent changes in the libraries, which means we will need to wait to publish this template preview until after the next libraries release. /cc @jmatthiesen

Copy link
Member

@SteveSandersonMS SteveSandersonMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really excellent! I know there are still a few pending questions and points but this is such a big and complicated area I think we should prioritize getting it merged and separately tracking the smaller follow-ups that remain.

)

* Added support for OTel semantic conventions for GenAI, when using Aspire support.

* Reverted changes that were not needed to enable genAI conventions.

* Update src/ProjectTemplates/Microsoft.Extensions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData-CSharp.Web/Program.Aspire.cs

Co-authored-by: Steve Sanderson <[email protected]>

* Added OTel fixes for Ollama as well.

---------

Co-authored-by: Steve Sanderson <[email protected]>
@MackinnonBuck MackinnonBuck merged commit 34cd461 into main Mar 28, 2025
6 checks passed
@MackinnonBuck MackinnonBuck deleted the mbuck/chat-template-aspire branch March 28, 2025 19:30
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-ai-templates Microsoft.Extensions.AI.Templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add .NET Aspire support to AI Chat Web App template
9 participants