[Telemetry, Logging] Emit {OriginalFormat} as the last property of the log record #6111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now {OriginalFormat} is emitted as the last item in the TagArray
Adjusts ExtendedLogger to always return {OriginalFormat} as the last tag in the list
iliar-turdushev
commented
Mar 16, 2025
Fixes ResourceMonitoring tests
src/Libraries/Microsoft.Extensions.Telemetry/Logging/ExtendedLogger.LegacyTagJoiner.cs
Outdated
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.Telemetry/Logging/ExtendedLogger.ModernTagJoiner.cs
Outdated
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.Telemetry/Logging/ExtendedLogger.ModernTagJoiner.cs
Outdated
Show resolved
Hide resolved
Address PR comments
iliar-turdushev
changed the title
dariusclay
approved these changes
Mar 17, 2025
evgenyfedorov2
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the source-generated logging and the
ExtendedLoggerto emit the{OriginalFormat}property as the last item of the log record.Fixes #5720
Microsoft Reviewers: Open in CodeFlow