-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More OpenTelemetry changes #18246
base: main
Are you sure you want to change the base?
More OpenTelemetry changes #18246
Conversation
❗ Release notes requiredCaution No release notes found for the changed paths (see table below). Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format. The following format is recommended for this repository:
If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request. You can open this PR in browser to add release notes: open in github.dev
|
Slightly less allocations. main:
this PR:
|
@@ -45,6 +45,8 @@ module internal Activity = | |||
|
|||
val addEvent: name: string -> unit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for nitpicking, but I think from the naming perspective, addEvent
and logEvent
are synonyms and synonyms are confusing in APIs. Maybe it could be just addEvent
and addEventWithTags
?
As with other OT changes, any Jaeger screenshots would be nice to have :) |
StackGuard.Guard
)