[CI] Pre-authorize AVD with ADB keys before starting the emulator #32730
+30
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
Author
|
Member
Author
|
Android UI tests - emulator started correctly: There are failing
|
PureWeen
approved these changes
Nov 19, 2025
Member
Author
|
All test failures are unrelated |
Copilot finished reviewing on behalf of
simonrozsival
November 19, 2025 14:32
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR attempts to fix "adb: device unauthorized" errors by pre-authorizing ADB keys before starting the Android emulator. It adds a new code block that ensures ADB keys exist and copies them to the AVD directory before boot, plus improves error logging in exception handlers.
Key changes:
- Pre-authorization logic that calls
EnsureAdbKeysand copies the public key to the AVD directory before emulator boot - Enhanced error handling with warning messages instead of silent catch blocks
Comment on lines
+463
to
+490
| // Pre-authorize ADB keys before starting emulator to avoid "device unauthorized" errors | ||
| Information("Pre-authorizing ADB keys for emulator..."); | ||
| try | ||
| { | ||
| // Ensure ADB keys exist | ||
| EnsureAdbKeys(adbSettings); | ||
|
|
||
| // Copy the public key to the AVD directory so it's trusted from boot | ||
| var homeDir = Environment.GetFolderPath(Environment.SpecialFolder.UserProfile); | ||
| var adbKeyPubSource = System.IO.Path.Combine(homeDir, ".android", "adbkey.pub"); | ||
| var avdPath = System.IO.Path.Combine(homeDir, ".android", "avd", $"{avdName}.avd"); | ||
| var avdAdbKeysDest = System.IO.Path.Combine(avdPath, "adbkey.pub"); | ||
|
|
||
| if (System.IO.File.Exists(adbKeyPubSource) && System.IO.Directory.Exists(avdPath)) | ||
| { | ||
| System.IO.File.Copy(adbKeyPubSource, avdAdbKeysDest, overwrite: true); | ||
| Information($"Pre-authorized ADB key copied to: {avdAdbKeysDest}"); | ||
| } | ||
| else | ||
| { | ||
| Warning($"Could not pre-authorize ADB key. Source exists: {System.IO.File.Exists(adbKeyPubSource)}, AVD path exists: {System.IO.Directory.Exists(avdPath)}"); | ||
| } | ||
| } | ||
| catch (Exception ex) | ||
| { | ||
| Warning($"Failed to pre-authorize ADB keys (will retry during boot): {ex.Message}"); | ||
| } | ||
|
|
There was a problem hiding this comment.
The pre-authorization approach may not work as intended. The standard Android emulator authorization mechanism expects authorized keys to be in /data/misc/adb/adb_keys on the running emulator, not in the AVD directory structure before boot.
Copying adbkey.pub to {avdName}.avd/adbkey.pub is not a documented Android emulator feature. The emulator reads authorized keys from its internal /data/misc/adb/adb_keys file at runtime, which is already handled by the existing EnsureAdbKeys function (see lines 951-992 where it pushes keys to /data/misc/adb/adb_keys).
Consider testing whether this pre-authorization actually prevents "device unauthorized" errors, or if the existing runtime authorization mechanism (already in EnsureAdbKeys) is sufficient.
Suggested change
| // Pre-authorize ADB keys before starting emulator to avoid "device unauthorized" errors | |
| Information("Pre-authorizing ADB keys for emulator..."); | |
| try | |
| { | |
| // Ensure ADB keys exist | |
| EnsureAdbKeys(adbSettings); | |
| // Copy the public key to the AVD directory so it's trusted from boot | |
| var homeDir = Environment.GetFolderPath(Environment.SpecialFolder.UserProfile); | |
| var adbKeyPubSource = System.IO.Path.Combine(homeDir, ".android", "adbkey.pub"); | |
| var avdPath = System.IO.Path.Combine(homeDir, ".android", "avd", $"{avdName}.avd"); | |
| var avdAdbKeysDest = System.IO.Path.Combine(avdPath, "adbkey.pub"); | |
| if (System.IO.File.Exists(adbKeyPubSource) && System.IO.Directory.Exists(avdPath)) | |
| { | |
| System.IO.File.Copy(adbKeyPubSource, avdAdbKeysDest, overwrite: true); | |
| Information($"Pre-authorized ADB key copied to: {avdAdbKeysDest}"); | |
| } | |
| else | |
| { | |
| Warning($"Could not pre-authorize ADB key. Source exists: {System.IO.File.Exists(adbKeyPubSource)}, AVD path exists: {System.IO.Directory.Exists(avdPath)}"); | |
| } | |
| } | |
| catch (Exception ex) | |
| { | |
| Warning($"Failed to pre-authorize ADB keys (will retry during boot): {ex.Message}"); | |
| } | |
| // Ensure ADB keys exist and are authorized at runtime | |
| EnsureAdbKeys(adbSettings); |
dalexsoto
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This is an attempt at fixing
adb: device unauthorized.by copying the ADB public key to the AVD before starting the emulator.Issues Fixed
Fixes #32601