Adding benchmarks for the new single/double math APIs #2540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannergooding
commented
Jul 29, 2022
| for (int iteration = 0; iteration < MathTests.Iterations; iteration++) | ||
| { | ||
| value += sinCosPiDelta; | ||
| // (float sinResult, float cosResult) = float.SinCosPi(value); |
There was a problem hiding this comment.
These functions should be updated to use the actual SinCosPi function once we move onto the next preview.
It is beneficial for them to exist beforehand to show the difference between calling individually vs the helper that reduces overall logic.
DrewScoggins
reviewed
Aug 4, 2022
DrewScoggins
reviewed
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These benchmarks follow the existing pattern used for the other math tests. This pattern was setup to avoid noise and other issues that BDN currently has with such small/highly optimized functions (such as dotnet/BenchmarkDotNet#1802).