-
Notifications
You must be signed in to change notification settings - Fork 279
Add build time measurement to Startup tool #4842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for introducing these. As a follow-up we should extend this to .NET sample app scenarios.
Is there an internal CI run where we can check the output of this measurements?
Co-authored-by: Matous Kozak <[email protected]>
Yes, invoked the internal CI. Sharing it offline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I only left few minor comments, thank you!
b6e3d06
Description
This PR adds support for measuring total build time in the
Startup
tool using binlog files.Changes
DownloadBuildArtifacts
task to retrieve binlog files from the build machinesrun_performance_job.py
to copy binlog files into the helix payload directoryStartup
tool to invokeBuildTimeParser
ILLink
and Mono-specific task timesValidation
Run the internal dotnet-runtime-perf tool to verify that
BuildTimeParser
collects build times.Out-of-scope
These measurements are collected from the build machines. With lack of any build time measurements atm, we want to standup these now and iterate later if needed. As suggested in dotnet/runtime#113073, apps build may be moved to Helix in the future.
Contributes to dotnet/runtime#113073