Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculate SuppressAddComponentParameter in tooling #10763
Calculate SuppressAddComponentParameter in tooling #10763
Changes from all commits
c92386f
45334b8
7fc2352
6794130
e685ca5
5cca44c
017a513
c77bce3
a3bab60
cc8f604
d3647a9
eca23cb
1f23c67
353e217
dcc4fe8
3d2f246
b108d41
4750b83
66c1790
73cfa13
41f69f9
4cf5339
4347cc3
1e2b4b0
5681389
b28e503
15e1635
72d5e84
2205c2e
4117df5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💭 Since this is the source generator, would it make sense to avoid the extra allocation and array copy caused by
ToImmutableArray()
? Something like this would effectively be allocation free until its known that there are any referenecs.