Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More hardening of the completion test #10904

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexgav
Copy link
Contributor

@alexgav alexgav commented Sep 19, 2024

We now wait for a specific item in the actual shown completion UI, and also wait for the correct text in the editor post-commit to account for actions such as OnAutoInsert

  1. We now actually open completion UI. Previously we may or may not have had the UI open, because IAsyncCompletionBroker.TriggerCompletion doesn't actually cause completion pop-up window UI to show (at least per doc comments). IAsyncCompletionSession.OpenOrUpdate actually shows completion window UI.
  2. We now wait for a specified item to be present and selected prior to trying to commit. We will re-update (re-calculate) completion items while waiting.
  3. We now wait for the correct text to be in the editor. After completion commit, there may be another action, such as OnAutoInsert that may modify the text further. We specify the final expected state of the text, so we should wait for it to be fully updated.

We not wait for a specific item in the actual shown completion UI, and also wait for the correct text in the editor post-commit to account for actions such as OnAutoInsert
@alexgav alexgav requested a review from a team as a code owner September 19, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant