Cohost wireup #11412
Draft
Cohost wireup #11412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chsienki
added
area-compiler
jjonescz
approved these changes
Jan 24, 2025
|
|
||
| namespace Microsoft.NET.Sdk.Razor.SourceGenerators | ||
| { | ||
| internal class RazorGeneratorResult(IReadOnlyList<TagHelperDescriptor> tagHelpers, ImmutableDictionary<string, (string hintName, RazorCodeDocument document)> documents) |
There was a problem hiding this comment.
Suggested change
| internal class RazorGeneratorResult(IReadOnlyList<TagHelperDescriptor> tagHelpers, ImmutableDictionary<string, (string hintName, RazorCodeDocument document)> documents) | |
| internal sealed class RazorGeneratorResult(IReadOnlyList<TagHelperDescriptor> tagHelpers, ImmutableDictionary<string, (string hintName, RazorCodeDocument document)> documents) |
| { | ||
| var (documents, tagHelpers) = pair; | ||
|
|
||
| var documentDictionary = documents.Select(p => new KeyValuePair<string, (string, RazorCodeDocument)>(p.codeDocument.Source.FilePath!, (p.hintName, p.codeDocument))).ToImmutableDictionary(); |
There was a problem hiding this comment.
Suggested change
| var documentDictionary = documents.Select(p => new KeyValuePair<string, (string, RazorCodeDocument)>(p.codeDocument.Source.FilePath!, (p.hintName, p.codeDocument))).ToImmutableDictionary(); | |
| var documentDictionary = documents.Select(p => KeyValuePair.Create(p.codeDocument.Source.FilePath!, (p.hintName, p.codeDocument))).ToImmutableDictionary(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wires up tooling to use the generator as the provider of documents.
It enables the generator in the cohosting tests and skips various tests that now fail (mostly because the mapping from the source-generated URI document format is missing back to the original razor doc).
I've kept some of the generation logic in tooling around as its still used by the formatting engine, but I've moved all of those parts under
!#FORMAT_FUSEso we can verify that's all they are used for.It also updates the cohosting flag in VS to completely disable the original language server if it's turned on, so there is only two states: co-hosting or not.