Support IsActiveDocument in RoslynCodeSearchResult #77311
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
| @@ -22,6 +22,7 @@ internal interface INavigateToSearchResult | |||
| string? Summary { get; } | |||
|
|
|||
| INavigableItem NavigableItem { get; } | |||
| bool IsActiveDocument { get; } | |||
There was a problem hiding this comment.
what will this be used for?
There was a problem hiding this comment.
do we need this if the searchresult already exposes NavigableItem? could we not just use that to see if the result's doc-id is the same as the original id?
There was a problem hiding this comment.
I'm not sure how I'd figure that out from within RoslynNavigateToSearchCallback
There was a problem hiding this comment.
i would think the active document would be available/captured into the callback. and its doc id could be compared against the doc id in NavigableItem.
|
This won't build until a corresponding change lands on the VS side. I just wanted to put drafts up on each side to get feedback on the approach. |
src/Features/Core/Portable/NavigateTo/AbstractNavigateToSearchService.NormalSearch.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.