Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing params to WhenEach overloads #107964

Merged
merged 4 commits into from
Sep 21, 2024

Conversation

stephentoub
Copy link
Member

These were approved and intended but likely missed due to coming in at approximately the same time that params span support was added.

These were approved and intended but likely missed due to coming in at approximately the same time that params span support was added.
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-threading-tasks
See info in area-owners.md if you want to be subscribed.

@stephentoub
Copy link
Member Author

/ba-g stuck leg

@stephentoub stephentoub merged commit fef878c into dotnet:main Sep 21, 2024
143 of 148 checks passed
@stephentoub stephentoub deleted the missingparams branch September 21, 2024 20:17
sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
These were approved and intended but likely missed due to coming in at approximately the same time that params span support was added.
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants