Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/9.0] Treat -rtm as stable sdk version band #107997

Open
wants to merge 3 commits into
base: release/9.0
Choose a base branch
from
+6 −5
Open

[release/9.0] Treat -rtm as stable sdk version band #107997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
106bbde
Treat -rtm versions as stable workload sdk bands
lewing Sep 18, 2024
a2cb890
Handle rtm specially here too
lewing Sep 18, 2024
79c1563
Merge branch 'release/9.0' into treat-rtm-stable-sdk-version-band
lewing Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
<!-- Enable to remove prerelease label. -->
<StabilizePackageVersion Condition="'$(StabilizePackageVersion)' == ''">false</StabilizePackageVersion>
<DotNetFinalVersionKind Condition="'$(StabilizePackageVersion)' == 'true'">release</DotNetFinalVersionKind>
<WorkloadVersionSuffix Condition="'$(DotNetFinalVersionKind)' != 'release' and '$(PreReleaseVersionIteration)' == ''">-$(PreReleaseVersionLabel)</WorkloadVersionSuffix>
<WorkloadVersionSuffix Condition="'$(WorkloadVersionSuffix)' == '' and '$(DotNetFinalVersionKind)' != 'release'">-$(PreReleaseVersionLabel).$(PreReleaseVersionIteration)</WorkloadVersionSuffix>
<WorkloadVersionSuffix Condition="'$(DotNetFinalVersionKind)' != 'release' and '$(PreReleaseVersionIteration)' == '' and '$(PreReleaseVersionLabel)' != 'rtm'">-$(PreReleaseVersionLabel)</WorkloadVersionSuffix>
<WorkloadVersionSuffix Condition="'$(WorkloadVersionSuffix)' == '' and '$(DotNetFinalVersionKind)' != 'release' and '$(PreReleaseVersionLabel)' != 'rtm'">-$(PreReleaseVersionLabel).$(PreReleaseVersionIteration)</WorkloadVersionSuffix>
<SdkBandVersionForWorkload_FromRuntimeVersions>$(SdkBandVersion)$(WorkloadVersionSuffix)</SdkBandVersionForWorkload_FromRuntimeVersions>
<!-- Set assembly version to align with major and minor version,
as for the patches and revisions should be manually updated per assembly if it is serviced. -->
Expand Down
2 changes: 1 addition & 1 deletion ...ono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
<Exec Condition="$(_DotNetVersionExitCode) != '0'" Command="$(_DotNetVersionCommand)" CustomErrorRegularExpression=".*" />

<PropertyGroup>
<SdkBandVersionForWorkload_ComputedFromInstaller>$(SdkBandVersion)$([System.Text.RegularExpressions.Regex]::Match($(_DotNetVersionOutput), `-[A-z]*[\.]*\d*`))</SdkBandVersionForWorkload_ComputedFromInstaller>
<SdkBandVersionForWorkload_ComputedFromInstaller>$(SdkBandVersion)$([System.Text.RegularExpressions.Regex]::Match($(_DotNetVersionOutput), `-(?!rtm)[A-z]*[\.]*\d*`))</SdkBandVersionForWorkload_ComputedFromInstaller>
<VersionBandForSdkManifestsDir Condition="'$(VersionBandForSdkManifestsDir)' == ''">$(SdkBandVersionForWorkload_ComputedFromInstaller)</VersionBandForSdkManifestsDir>
<VersionBandForManifestPackages Condition="'$(VersionBandForManifestPackages)' == ''">$(VersionBandForSdkManifestsDir)</VersionBandForManifestPackages>
</PropertyGroup>
Expand Down Expand Up @@ -198,7 +198,7 @@

<Message Text="Packages found in $(BuiltNugetsDir): @(_BuiltNuGets)" Importance="Low" />

<InstallWorkloadFromArtifacts

Check failure on line 201 in src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets

View check run for this annotation

Azure Pipelines / runtime (Build wasi-wasm linux Release WasmBuildTests)

src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets#L201 

src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets(201,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Restoring packages failed with exit code: 1. Output:
  Determining projects to restore...
/__w/1/s/artifacts/obj/workload-5s2jdxis.wbc/fb4uzixj.qf2/restore/Restore.csproj : error NU1101: Unable to find package Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100. No packages exist with this id in source(s): dotnet-eng, dotnet-libraries, dotnet-libraries-transport, dotnet-public, dotnet-tools, dotnet9, dotnet9-transport, nuget-local
  Failed to restore /__w/1/s/artifacts/obj/workload-5s2jdxis.wbc/fb4uzixj.qf2/restore/Restore.csproj (in 360 ms).

Check failure on line 201 in src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets

View check run for this annotation

Azure Pipelines / runtime (Build wasi-wasm linux Release WasmBuildTests)

src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets#L201 

src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets(201,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Could not install manifest Microsoft.NET.Workload.Emscripten.Current/9.0.0-rc.2.24464.3. This can be ignored if the workload wasi-experimental doesn't depend on it.

Check failure on line 201 in src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets

View check run for this annotation

Azure Pipelines / runtime (Build wasi-wasm linux Release WasmBuildTests)

src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets#L201 

src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets(201,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Workload installation failed: Workload manifest dependency 'Microsoft.NET.Workload.Emscripten.Current' version '9.0.0-rc.2.24455.1' is lower than version '9.0.0-rc.2.24464.3' required by manifest 'microsoft.net.workload.mono.toolchain.current' [/__w/1/s/artifacts/bin/dotnet-latest/sdk-manifests/9.0.100-rc.2/microsoft.net.workload.mono.toolchain.current/9.0.0-rc.2.24462.10/WorkloadManifest.json]

Check failure on line 201 in src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets

View check run for this annotation

Azure Pipelines / runtime (Build wasi-wasm linux Release WasmBuildTests)

src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets#L201 

src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets(201,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) workload install failed with exit code 1: Workload installation failed: Workload manifest dependency 'Microsoft.NET.Workload.Emscripten.Current' version '9.0.0-rc.2.24455.1' is lower than version '9.0.0-rc.2.24464.3' required by manifest 'microsoft.net.workload.mono.toolchain.current' [/__w/1/s/artifacts/bin/dotnet-latest/sdk-manifests/9.0.100-rc.2/microsoft.net.workload.mono.toolchain.current/9.0.0-rc.2.24462.10/WorkloadManifest.json]

Check failure on line 201 in src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets

View check run for this annotation

Azure Pipelines / runtime (Build browser-wasm linux Release WasmBuildTests)

src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets#L201 

src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets(201,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Restoring packages failed with exit code: 1. Output:
  Determining projects to restore...
/__w/1/s/artifacts/obj/workload-glywjely.gbi/scpuojie.di3/restore/Restore.csproj : error NU1101: Unable to find package Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100. No packages exist with this id in source(s): dotnet-eng, dotnet-libraries, dotnet-libraries-transport, dotnet-public, dotnet-tools, dotnet9, dotnet9-transport, nuget-local
  Failed to restore /__w/1/s/artifacts/obj/workload-glywjely.gbi/scpuojie.di3/restore/Restore.csproj (in 359 ms).

Check failure on line 201 in src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets

View check run for this annotation

Azure Pipelines / runtime (Build browser-wasm linux Release WasmBuildTests)

src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets#L201 

src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets(201,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Could not install manifest Microsoft.NET.Workload.Emscripten.Current/9.0.0-rc.2.24464.3. This can be ignored if the workload wasm-tools doesn't depend on it.

Check failure on line 201 in src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets

View check run for this annotation

Azure Pipelines / runtime (Build browser-wasm linux Release WasmBuildTests)

src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets#L201 

src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets(201,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Workload installation failed: Workload manifest dependency 'Microsoft.NET.Workload.Emscripten.Current' version '9.0.0-rc.2.24455.1' is lower than version '9.0.0-rc.2.24464.3' required by manifest 'microsoft.net.workload.mono.toolchain.current' [/__w/1/s/artifacts/bin/dotnet-latest/sdk-manifests/9.0.100-rc.2/microsoft.net.workload.mono.toolchain.current/9.0.0-rc.2.24462.10/WorkloadManifest.json]

Check failure on line 201 in src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets

View check run for this annotation

Azure Pipelines / runtime (Build browser-wasm linux Release WasmBuildTests)

src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets#L201 

src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets(201,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) workload install failed with exit code 1: Workload installation failed: Workload manifest dependency 'Microsoft.NET.Workload.Emscripten.Current' version '9.0.0-rc.2.24455.1' is lower than version '9.0.0-rc.2.24464.3' required by manifest 'microsoft.net.workload.mono.toolchain.current' [/__w/1/s/artifacts/bin/dotnet-latest/sdk-manifests/9.0.100-rc.2/microsoft.net.workload.mono.toolchain.current/9.0.0-rc.2.24462.10/WorkloadManifest.json]
WorkloadIds="@(WorkloadIdForTesting)"
InstallTargets="@(_SdkWithWorkloadToInstall)"
VersionBandForSdkManifestsDir="$(VersionBandForSdkManifestsDir)"
Expand Down
5 changes: 3 additions & 2 deletions src/tasks/WorkloadBuildTasks/InstallWorkloadFromArtifacts.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public partial class InstallWorkloadFromArtifacts : PatchNuGetConfig
ReadCommentHandling = JsonCommentHandling.Skip
};

[GeneratedRegex(@"^\d+\.\d+\.\d+(-[A-z]*\.*\d*)?")]
[GeneratedRegex(@"^\d+\.\d+\.\d+(-(?!rtm)[A-z]*\.*\d*)?")]
private static partial Regex bandVersionRegex();

public override bool Execute()
Expand Down Expand Up @@ -301,7 +301,8 @@ private bool InstallWorkloadManifest(ITaskItem workloadId, string name, string v
if (!string.IsNullOrEmpty(bandPreleaseVersion) &&
packagePreleaseVersion != bandPreleaseVersion &&
packagePreleaseVersion != "-dev" &&
packagePreleaseVersion != "-ci")
packagePreleaseVersion != "-ci" &&
packagePreleaseVersion != "-rtm")
{
bandVersion = bandVersion.Replace (bandPreleaseVersion, packagePreleaseVersion);
}
Expand Down
Loading