[PERF] Fix the perf r2rRunType and pgoRunType argument formats for new flow #108038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lude dashes, fixing their passing into the new perf flow added in commit b14e2f5.
LoopedBard3
changed the title
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
caaavik-msft
approved these changes
Sep 19, 2024
DrewScoggins
approved these changes
Sep 19, 2024
caaavik-msft
pushed a commit
to caaavik-msft/runtime
that referenced
this pull request
Sep 26, 2024
…lude dashes, fixing their passing into the new perf flow added in commit b14e2f5. (dotnet#108038)
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
…lude dashes, fixing their passing into the new perf flow added in commit b14e2f5. (dotnet#108038)
jeffschwMSFT
added a commit
that referenced
this pull request
Oct 4, 2024
…tests (#108412) * backport #105451 to release/9.0 * Update the perf r2rRunType and pgoRunType argument formats to not include dashes, fixing their passing into the new perf flow added in commit b14e2f5. (#108038) * Pass ScenarioArgs for scenario projects --------- Co-authored-by: Parker Bibus <[email protected]> Co-authored-by: Jeff Schwartz <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the perf r2rRunType and pgoRunType argument formats to not include dashes, fixing their passing into the new perf flow added in commit b14e2f5. The issue we were hitting was arguments such as --r2r-run-type being passed the r2rRunType with the dashes, causing it to not correctly get parsed as an argument. (--r2r-run-type --nodynamicpgo was passed instead of --r2r-run-type nodynamicpgo). Also matched the letter casing for both.