Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name native threads before start (macOS/Native AOT) #114249

Merged
merged 8 commits into from
Apr 10, 2025
Merged

Name native threads before start (macOS/Native AOT) #114249

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7608914
Name native threads before start on macOS
eduardo-vp Apr 4, 2025
abefa1b
Make sure ThreadStart is always initialized with the thread on OS x
eduardo-vp Apr 4, 2025
d0178e1
Use Thread.CurrentThread
eduardo-vp Apr 4, 2025
eaef706
Check if CI passes commenting the line that changes the thread name
eduardo-vp Apr 4, 2025
18c9010
Add test
eduardo-vp Apr 9, 2025
37ea2b2
Make the test specific to Windows
eduardo-vp Apr 9, 2025
caa8e83
Remove test
eduardo-vp Apr 9, 2025
cf44e16
Remove link to the github issue
eduardo-vp Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/libraries/System.Private.CoreLib/src/System/Threading/Thread.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,18 @@ private void RunWorker()

try
{
#if TARGET_OSX || NATIVEAOT
// On other platforms, when the underlying native thread is created,
// the thread name is set to the name of the managed thread by another thread.
// However, on OS X and NativeAOT (across all OSes), only the thread itself can set its name.
// Therefore, by this point the native thread is still unnamed as it has not started yet.
Thread thread = Thread.CurrentThread;
if (!string.IsNullOrEmpty(thread.Name))
{
// Name the underlying native thread to match the managed thread name.
thread.ThreadNameChanged(thread.Name);
}
#endif
if (start is ThreadStart threadStart)
{
threadStart();
Expand Down
Loading