Remove GetSystemTime/GetSystemTimeAsFileTime from PAL #119543
+104
−754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
huoyaoyuan
commented
Sep 10, 2025
| { | ||
| STATIC_CONTRACT_NOTHROW; | ||
|
|
||
| #ifdef HOST_WINDOWS |
There was a problem hiding this comment.
This is duplicating the code from aot EventPipe. They are the only users of system time now and wrapping through minipal can introduce unnecessary complexity. Maybe we can share code among EventPipe implementations as many functions are moving to minipal?
| CRITSEC_COOKIE lock; // lock | ||
| uint64_t tickFrequency; // number of ticks per second | ||
| uint64_t startTimeStamp; // start time from when tick counter started | ||
| FILETIME startTime; // time the application started |
There was a problem hiding this comment.
This field is specified in StressLog cdac, but not used. Is it fine to change it? The bit order of FILETIME should be the same with int64 on LE.
| #ifndef TARGET_UNIX | ||
| GetLocalTime(&st); | ||
| struct timespec ts; | ||
| int ret = timespec_get(&ts, TIME_UTC); |
There was a problem hiding this comment.
This method is debug only. This should be the simplest code that works cross platform.
Co-authored-by: Michał Petryka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.