[release/10.0] Limit the use of a pointer to the lexical scope of the target #120387
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
…/Cryptography/X509Certificates/StorePal.Windows.Export.cs Co-authored-by: Jan Kotas <[email protected]>
bartonjs
approved these changes
Oct 3, 2025
bartonjs
added
area-System.Security
Servicing-consider
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
This was referenced Oct 4, 2025
agocke
approved these changes
Oct 6, 2025
artl93
approved these changes
Oct 6, 2025
artl93
added
Servicing-approved
|
/ba-g All failures are already marked as "known" from #120353 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #120342 to release/10.0
/cc @bartonjs
Customer Impact
The code used a pointer to a stack value after the value had exited its lexical scope.
While that works in practice, it's an undefined behavior.
Regression
New code in .NET 10, was committed this way.
Testing
Adequate coverage exists with unit tests.
Risk
Low. Mechanical change with high test coverage.