Skip to content

JIT: Disallow using float callee saves in x64 functions with patchpoints #127158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakobbotsch merged 3 commits into from
Apr 21, 2026
Merged

JIT: Disallow using float callee saves in x64 functions with patchpoints #127158

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
faa2c1c
JIT: Disallow using float callee saves in x64 functions with patchpoints
jakobbotsch Apr 20, 2026
493c885
Feedback
jakobbotsch Apr 20, 2026
61bd3e4
Remove RBM_MSK_CALLEE_SAVED for future proofing
jakobbotsch Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/coreclr/jit/lsra.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -984,6 +984,21 @@ LinearScan::LinearScan(Compiler* theCompiler)
}
#endif // TARGET_AMD64 || TARGET_ARM64

#ifdef TARGET_AMD64
Comment thread
jakobbotsch marked this conversation as resolved.
// On x64 the OSR method does not restore float registers from tier0 frame,
// so disallow using float callee saves in the tier0 method.
if (m_compiler->doesMethodHavePatchpoints() || m_compiler->doesMethodHavePartialCompilationPatchpoints())
{
#if defined(UNIX_AMD64_ABI)
availableFloatRegs &= ~RBM_FLT_CALLEE_SAVED;
availableDoubleRegs &= ~RBM_FLT_CALLEE_SAVED;
#else
availableFloatRegs &= ~RBM_FLT_CALLEE_SAVED.GetFloatRegSet();
availableDoubleRegs &= ~RBM_FLT_CALLEE_SAVED.GetFloatRegSet();
#endif // UNIX_AMD64_ABI
}
Comment thread
tannergooding marked this conversation as resolved.
Outdated
Comment thread
jakobbotsch marked this conversation as resolved.
#endif
Comment thread
jakobbotsch marked this conversation as resolved.

#if defined(TARGET_AMD64)
if (evexIsSupported)
{
Expand Down
Loading