Skip to content

Conversation

BartoszKlonowski
Copy link
Contributor

This pull request is the follow-up to the dotnet/docs#48202 PR that makes the project now use GetFromJsonAsync instead of DeserializeAsync.
To keep the code up-to-date this PR also makes sure that the new version of .NET is used instead of old v6.

For more info please check the mentioned PR to docs repository.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BartoszKlonowski

I had one optional comment. I'll merge after we finish dotnet/docs#48202

@@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to use .NET 9 instead of 8.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Let's :shipit:

@BillWagner BillWagner merged commit 9d3bddf into dotnet:main Sep 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants