Sign and harden pkgs #47996
Open
Sign and harden pkgs #47996
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
ellahathaway
approved these changes
Mar 28, 2025
eng/Signing.props
Outdated
| @@ -64,6 +64,11 @@ | |||
| <FileSignInfo Include="xunit.performance.execution.dll" CertificateName="$(ExternalCertificateId)" /> | |||
| <FileSignInfo Include="xunit.performance.metrics.dll" CertificateName="$(ExternalCertificateId)" /> | |||
| <FileSignInfo Include="Valleysoft.DockerCredsProvider.dll" CertificateName="$(ExternalCertificateId)" /> | |||
|
|
|||
| <!- Explicitly notarize the outer sdk pkgs --> | |||
There was a problem hiding this comment.
I think this comment has to be adjusted. Otherwise LGTM.
Suggested change
| <!- Explicitly notarize the outer sdk pkgs --> | |
| <!-- Explicitly notarize the outer sdk pkgs --> |
3 tasks
|
Failed to notarize so need to look into what it thinks isn't signed in the pkgs |
|
Need to merge and flow the runtime change before this goes in, or notarization will fail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.