Apply dotnetup code review feedback #51711
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splits up `ReleaseManifest` into 3 pieces: - A. Downloading of .NET Archives - B. Accessing the release manifest & release manifest data structures - C. Parsing a 'channel' into a ReleaseVersion This is a better separation of responsibility and makes each class a far more reasonable size. # Conflicts: # src/Installer/Microsoft.Dotnet.Installation/Internal/ArchiveDotnetExtractor.cs # src/Installer/Microsoft.Dotnet.Installation/Internal/ReleaseManifest.cs # src/Installer/dnup/Commands/Sdk/Install/SdkInstallCommand.cs
What we were doing was setting the AppContext data such that the HOSTFXR_PATH pointed to the installed root location. We don't need to do that, the hostfxr interop(ped) API already points to the dotnet root location within which we want to resolve the hostfxr.
verification should happen in the downloader which will probably be deferred to the release deployment library
This was referenced Nov 13, 2025
baronfel
approved these changes
Nov 15, 2025
Member
baronfel
left a comment
baronfel
left a comment
There was a problem hiding this comment.
Some things that jumped out at me as I was checking this out this evening.
| }; | ||
|
|
||
| // Set user-agent to identify dnup in telemetry | ||
| client.DefaultRequestHeaders.UserAgent.ParseAdd("dnup-dotnet-installer"); |
Member
There was a problem hiding this comment.
nit: we should embed library version here, retrieved from the AssemblyInformation attributes.
| /// <param name="progress">Optional progress reporting</param> | ||
| void DownloadArchive(string downloadUrl, string destinationPath, IProgress<DownloadProgress>? progress = null) | ||
| { | ||
| DownloadArchiveAsync(downloadUrl, destinationPath, progress).GetAwaiter().GetResult(); |
Member
There was a problem hiding this comment.
I think we're going to need to unblock all of this async usage. In 2025 we should not be creating libraries that block threads. Do we have a work item to do this already?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase and continuation of #51446, which responded to general dotnetup code review feedback from #50988.
Subsequently, I've addressed some of my own code review feedback from the previous PR.