-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added WorkingDirectory property for #7471 #7472
Conversation
Thank you! This is a great start, there are a few things that need to happen to get this green:
|
@baronfel I will check those feedback. |
@baronfel Have updated the advised details, can you review again and let me if anything more is to be done. |
This looks pretty good to me! There aren't tests for the existing built-ins, so as soon as you can fix the build error around the API surface area this should be good to merge :) |
This is the error message: src\Microsoft.TemplateEngine.Edge\PublicAPI.Unshipped.txt(11,1): error RS0025: (NETCORE_ENGINEERING_TELEMETRY=Build) The symbol 'Microsoft.TemplateEngine.Edge.DefaultTemplateEngineHost.WorkingDirectory.get -> string!' appears more than once in the public API files (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) Should I remove these API details from the Unshipped file? |
It looks like the same line is present multiple times - so just removing the duplicates should be all that you need to do. |
After removing the entry from the Unshipped file, all checks have passed. Can you proceed with the merge? |
@baronfel can you look into this PR and let me know if anything else needs to be done? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @baronfel, Can the PR be merged as the changes are approved? |
Thanks :-) |
@baronfel, From which .NET SDK version, this property will be made available? |
Either .NET SDK 9.0.100-preview.6 (last month's preview) or 9.0.100-preview.7 (this month's preview) |
Ok thanks, will check. |
Problem
#7471
Solution
Added a property that returns the current directory (have named it
WorkingDirectory
) from where the dotnet command is invoked.Checks: