Consider Runtime Patch Versions in PATH API #2008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The C# extension will now fail if the runtime is not 8.0.10 or higher on mac so we need to support patch version lookup. Sadly we cannot migrate to semver because semver rejects strings such as 8.0 which are allowable in many parts of our code and APIs. This also adds code for SDK lookup but no test since that's harder to test, like remarked in the code.
MiYanni
approved these changes
Nov 4, 2024
nagilson
commented
Nov 4, 2024
vscode-dotnet-runtime-extension/src/test/functional/DotnetCoreAcquisitionExtension.test.ts
Outdated
Show resolved
Hide resolved
We now parse all of the version, dont need to do this logic.
|
Thanks Yanni for your review 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C# extension will now fail if the runtime is not 8.0.10 or higher on mac so we need to support patch version lookup.
Sadly we cannot migrate to semver as described in #2003 because semver rejects strings such as 8.0 which are allowable in many parts of our code and APIs.(Thank you to @baronfel for seeing this comment and telling me about semver.coerce. Except, I dont really want to rewrite the code again now after writing it once already, gah)This also adds code for SDK lookup but no test since that's harder to test, like remarked in the code.