Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Runtime Patch Versions in PATH API #2008

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

nagilson
Copy link
Member

@nagilson nagilson commented Nov 4, 2024

The C# extension will now fail if the runtime is not 8.0.10 or higher on mac so we need to support patch version lookup.

Sadly we cannot migrate to semver as described in #2003 because semver rejects strings such as 8.0 which are allowable in many parts of our code and APIs. (Thank you to @baronfel for seeing this comment and telling me about semver.coerce. Except, I dont really want to rewrite the code again now after writing it once already, gah)

This also adds code for SDK lookup but no test since that's harder to test, like remarked in the code.

The C# extension will now fail if the runtime is not 8.0.10 or higher on mac so we need to support patch version lookup.

Sadly we cannot migrate to semver because semver rejects strings such as 8.0 which are allowable in many parts of our code and APIs.

This also adds code for SDK lookup but no test since that's harder to test, like remarked in the code.
@nagilson nagilson requested a review from a team November 4, 2024 22:01
@nagilson
Copy link
Member Author

nagilson commented Nov 5, 2024

Thanks Yanni for your review 😄

@nagilson nagilson enabled auto-merge (squash) November 5, 2024 18:32
@nagilson nagilson merged commit c86868f into dotnet:main Nov 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants