Skip to content

Updates/v3.8 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Conversation

Houzvicka
Copy link

As discussed in the #30
Update of library to version 3.8

@Houzvicka Houzvicka mentioned this pull request Dec 18, 2023
@@ -932,7 +932,7 @@ private void SetImageSource( MessageBoxImage image )
}

// Use this syntax for other themes to get the icons
this.ImageSource = new BitmapImage( new Uri( String.Format( "/DotNetProjects.Wpf.Extended.Toolkit;component/MessageBox/Icons/{0}", iconName ), UriKind.RelativeOrAbsolute ) );
this.ImageSource = new BitmapImage( new Uri( String.Format( "/Xceed.Wpf.Toolkit;component/MessageBox/Icons/{0}", iconName ), UriKind.RelativeOrAbsolute ) );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work? As the Project is not named Xceed

@@ -19,8 +19,8 @@
xmlns:core="clr-namespace:Xceed.Wpf.Toolkit.Core">

<ResourceDictionary.MergedDictionaries>
<core:VersionResourceDictionary AssemblyName="DotNetProjects.Wpf.Extended.Toolkit" SourcePath="Themes/Aero/Brushes_NormalColor.xaml"/>
<core:VersionResourceDictionary AssemblyName="DotNetProjects.Wpf.Extended.Toolkit"
<core:VersionResourceDictionary AssemblyName="Xceed.Wpf.Toolkit" SourcePath="Themes/Aero/Brushes_NormalColor.xaml"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here...

<ResourceDictionary Source="/DotNetProjects.Wpf.Extended.Toolkit;component/Wizard/Themes/Aero2.NormalColor.xaml" />
<ResourceDictionary Source="/DotNetProjects.Wpf.Extended.Toolkit;component/Zoombox/Themes/Aero2.NormalColor.xaml" />
</ResourceDictionary.MergedDictionaries>
<ResourceDictionary Source="/Xceed.Wpf.Toolkit;component/Themes/Aero2/Brushes.xaml" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here


<core:VersionResourceDictionary AssemblyName="DotNetProjects.Wpf.Extended.Toolkit" SourcePath="TokenizedTextBox/Themes/Generic.xaml" />
</ResourceDictionary.MergedDictionaries>
<core:VersionResourceDictionary AssemblyName="Xceed.Wpf.Toolkit" SourcePath="Themes/Generic/Brushes.xaml" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I overlooked these. And also create a simple app to test, and you are right. So I made the changes, and now it works correctly :)

@jogibear9988
Copy link
Member

lgtm

@jogibear9988 jogibear9988 merged commit 9df4a40 into dotnetprojects:Extended Dec 18, 2023
@jogibear9988
Copy link
Member

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants