Add support for deletion tracking in ClickHouse sink tables #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce `__data_transfer_is_deleted` generated column for tracking deletions - Update ClickHouse destination model to support deletable flag - Extend sink parameters interface with `IsDeleteable()` method - Automatically derive deletable status from transfer options Closes: #219
- Add `IsDeleteable` field to `ChSource` struct - Implement `IsDeleteable()` method for `ChSourceWrapper` - Add `ToSinkParams()` method to create a copy of source with deletable flag set to false by default
|
|
|
@laskoviymishka has imported your pull request. If you are a member of Transfer team, you can view this diff. |
|
✅ This pull request is being closed because it has been successfully merged into our internal monorepository. |
robot-piglet
pushed a commit
that referenced
this pull request
Feb 28, 2025
- Introduce `__data_transfer_is_deleted` generated column for tracking deletions - Update ClickHouse destination model to support deletable flag - Infer is\_deleted usage based on clickhouse version - Include is\_deleted flag into replacing merge tree Closes: <#219> --- Pull Request resolved: <#231> Co-authored-by: tserakhau <[email protected]> Co-authored-by: tserakhau <[email protected]> Co-authored-by: tserakhau <[email protected]> Co-authored-by: tserakhau <[email protected]> Co-authored-by: tserakhau <[email protected]> Co-authored-by: tserakhau <[email protected]> commit_hash:9e5d0898877ded9792fa13e1f24b60e9f216e875
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__data_transfer_is_deletedgenerated column for tracking deletionsIsDeleteable()methodCloses: #219