Hera/Improve parity #1337
Open
Hera/Improve parity #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 092517d.
caitmich
reviewed
Feb 13, 2025
caitmich
reviewed
Feb 13, 2025
| @@ -26,34 +50,18 @@ def flash_messages | |||
| end.join("\n").html_safe | |||
| end | |||
|
|
|||
| def in_project? | |||
| defined?(current_project) && current_project&.persisted? | |||
There was a problem hiding this comment.
Suggested change
| defined?(current_project) && current_project&.persisted? | |
| current_project && current_project.persisted? |
There was a problem hiding this comment.
we don't need the safeguard since we shouldn't end up on the right side of this expression unless current_project exists
There was a problem hiding this comment.
defined?(current_project) returns "method" but we only need to check whether it's nil or not
There was a problem hiding this comment.
Unless this is due to a strange case where it's defined and not set? There is probably a nicer way to handle this case
caitmich
reviewed
Feb 13, 2025
| 'in-project': in_project? | ||
| ), | ||
| data: { | ||
| env: (Rails.env unless Rails.env.production?), |
There was a problem hiding this comment.
What's the purpose of this line?
Co-authored-by: Caitlin Henry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR brings additional CSS to improve parity between Dradis CE and Dradis Pro.
Check List