chore(hset_family): Code cleaning #5882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorysTheDev
reviewed
Oct 6, 2025
BorysTheDev
reviewed
Oct 6, 2025
BorysTheDev
reviewed
Oct 6, 2025
Comment on lines
+1245
to
+1262
| *registry << CI{"HDEL", CO::FAST | CO::WRITE, -3, 1, 1}.HFUNC(HDel) | ||
| << CI{"HLEN", CO::FAST | CO::READONLY, 2, 1, 1}.HFUNC(HLen) | ||
| << CI{"HEXISTS", CO::FAST | CO::READONLY, 3, 1, 1}.HFUNC(HExists) | ||
| << CI{"HGET", CO::FAST | CO::READONLY, 3, 1, 1}.HFUNC(HGet) | ||
| << CI{"HGETALL", CO::FAST | CO::READONLY, 2, 1, 1}.HFUNC(HGetAll) | ||
| << CI{"HMGET", CO::FAST | CO::READONLY, -3, 1, 1}.HFUNC(HMGet) | ||
| << CI{"HMSET", CO::WRITE | CO::FAST | CO::DENYOOM, -4, 1, 1}.HFUNC(HSet) | ||
| << CI{"HINCRBY", CO::WRITE | CO::DENYOOM | CO::FAST, 4, 1, 1}.HFUNC(HIncrBy) | ||
| << CI{"HINCRBYFLOAT", CO::WRITE | CO::DENYOOM | CO::FAST, 4, 1, 1}.HFUNC(HIncrByFloat) | ||
| << CI{"HKEYS", CO::READONLY, 2, 1, 1}.HFUNC(HKeys) | ||
| << CI{"HEXPIRE", CO::WRITE | CO::FAST | CO::DENYOOM, -5, 1, 1}.HFUNC(HExpire) | ||
| << CI{"HRANDFIELD", CO::READONLY, -2, 1, 1}.HFUNC(HRandField) | ||
| << CI{"HSCAN", CO::READONLY, -3, 1, 1}.HFUNC(HScan) | ||
| << CI{"HSET", CO::WRITE | CO::FAST | CO::DENYOOM, -4, 1, 1}.HFUNC(HSet) | ||
| << CI{"HSETEX", CO::WRITE | CO::FAST | CO::DENYOOM, -5, 1, 1}.SetHandler(HSetEx) | ||
| << CI{"HSETNX", CO::WRITE | CO::DENYOOM | CO::FAST, 4, 1, 1}.HFUNC(HSetNx) | ||
| << CI{"HSTRLEN", CO::READONLY | CO::FAST, 3, 1, 1}.HFUNC(HStrLen) | ||
| << CI{"HVALS", CO::READONLY, 2, 1, 1}.HFUNC(HVals); |
There was a problem hiding this comment.
why do not we need acl::* flags anymore?
There was a problem hiding this comment.
If you don't pass the acl flag, it will be determined by the command flags. It should have been this way from the start.
I've checked COMMAND output, the acl flags didn't change
BorysTheDev
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to add tiering capabilities in the future. The code is quite verbose and there are parts that are either copied or have no real effect (are redundant)