[Wisp] only test c1 assertion failure in slowdebug mode #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jia-wei-tang
force-pushed
the
dev
branch
3 times, most recently
from
6bb567f
to
64e5be6
Compare
jia-wei-tang
changed the title
jia-wei-tang
changed the title
Summary: Determine the java mode before run normal logics. If java is release or fastdebug, just go to the ending early. Testing: hotspot/test/runtime/coroutine/c1AssertFailTest.sh Reviewers: lingjun-cg, yulei Issue: dragonwell-project#605
yuleil
approved these changes
Dec 11, 2023
lingjun-cg
approved these changes
Dec 11, 2023
| Function getNewPkg = new Function<Object, Object>() { | ||
| @Override | ||
| public java.lang.Object apply(java.lang.Object t) { | ||
| return new_pkg; |
There was a problem hiding this comment.
new_pkg换成newPkg吧，一般java不会使用下划线的风格
There was a problem hiding this comment.
这个修改我之后要再开一个pr对应一个新的issue，稍后修改
| @@ -125,8 +125,7 @@ public void testLogging() throws IOException { | |||
| "-Djava.security.manager", | |||
| "com.example.TestLambda"); | |||
| // dump/com/example + 2 class files | |||
| // dump/java/lang + 1 class file | |||
| assertEquals(Files.walk(Paths.get("dump")).count(), 8, "Two lambda captured"); | |||
| assertEquals(Files.walk(Paths.get("dump")).count(), 5, "Two lambda captured"); | |||
There was a problem hiding this comment.
这里原本ClassLoader.java里使用lambda后会增加3个，但是现在为了解决bug，需要去除lambda，这里的数量需要减少（其实和最初是一致的，可以看之前的pr: https://github.com/dragonwell-project/dragonwell8/pull/600）
这个修改也会和上面的一起放到新的pr里
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Determine the java mode before run normal logics.
If java is release or fastdebug, just go to the ending early.
Testing: hotspot/test/runtime/coroutine/c1AssertFailTest.sh
Reviewers: lingjun-cg, yulei
Issue: #605