Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GC] Fix option type in IOPrioritySizePolicy #663

Merged
merged 1 commit into from
Aug 2, 2024
Merged

[GC] Fix option type in IOPrioritySizePolicy #663

merged 1 commit into from
Aug 2, 2024

Conversation

weixlu
Copy link
Collaborator

@weixlu weixlu commented Aug 2, 2024

Summary: change type from float to uint for IOPrioritySizePolicyEdenScale to avoid build failure on aarch64

Testing: maoliang.ml, yude.lyd

Reviewers: maoliang.ml, yude.lyd

Issue: #664

CR: #663

weixlu added a commit that referenced this pull request Aug 2, 2024
Summary: change type from float to uint for IOPrioritySizePolicyEdenScale to avoid build failure on aarch64

Testing: maoliang.ml, yude.lyd

Reviewers: maoliang.ml, yude.lyd

Issue: #664

CR: #663
@weixlu weixlu requested review from y1yang0 and linade August 2, 2024 09:14
Copy link
Collaborator

@linade linade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Summary: change type from float to uint for IOPrioritySizePolicyEdenScale to avoid build failure on aarch64

Testing: maoliang.ml, yude.lyd

Reviewers: maoliang.ml, yude.lyd

Issue: #664

CR: #663
@weixlu weixlu merged commit 5780594 into master Aug 2, 2024
19 checks passed
@weixlu weixlu deleted the fix-psgc branch August 5, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants