[Misc] optimize BigDecimal.divide #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Use binary search in zero stripping of BigDecimal.divide Testing: jtreg Reviewers: zhuoren.wz, JoshuaZhuwj Issue: #665
weixlu
changed the title
|
This a clean cherry-pick from dragonwell11. Spark on TPC-DS shows a similar performance gain as it does on dragonwell11. |
sandlerwang
reviewed
Aug 7, 2024
| @@ -198,9 +198,12 @@ | |||
| product(bool, UseIOPrioritySizePolicy, false, \ | |||
| "eagerly decrease heap when io wait is high") \ | |||
| \ | |||
| product(uintx, IOPrioritySizePolicyEdenScale, 8, \ | |||
There was a problem hiding this comment.
减了一个空格，因为没对齐。之前加IOPrioritySizePolicyEdenScale这个参数的时候没把这里的 \ 对齐
sandlerwang
approved these changes
Aug 7, 2024
JoshuaZhuwj
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Use binary search in zero stripping of BigDecimal.divide
Testing: jtreg
Reviewers: zhuoren.wz, JoshuaZhuwj
Issue: #665