Skip to content

NRW-8577: Removed FluentAssertions #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xjkl merged 2 commits into from
Jul 28, 2025
Merged

NRW-8577: Removed FluentAssertions #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f493c7
Removed FluentAssertions
DREXJKLI Jul 28, 2025
873b040
Enable tests in build action + use ubuntu latest
DREXJKLI Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-push-nuget.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@ on:

jobs:
build:
runs-on: ubuntu-18.04
runs-on: ubuntu-latest
defaults:
run:
working-directory: .
name: Update NuGet package
env:
PACKAGE_PROJECT: NLog.Slack
TEST_PROJECT:
TEST_PROJECT: NLog.Slack.Tests
steps:

- name: Checkout repository
Expand Down
6 changes: 0 additions & 6 deletions NLog.Slack.Tests/NLog.Slack.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,6 @@
<WarningLevel>4</WarningLevel>
</PropertyGroup>
<ItemGroup>
<Reference Include="FluentAssertions">
<HintPath>..\packages\FluentAssertions.3.1.229\lib\net45\FluentAssertions.dll</HintPath>
</Reference>
<Reference Include="FluentAssertions.Core">
<HintPath>..\packages\FluentAssertions.3.1.229\lib\net45\FluentAssertions.Core.dll</HintPath>
</Reference>
<Reference Include="Microsoft.CSharp" />
<Reference Include="Moq">
<HintPath>..\packages\Moq.4.2.1408.0717\lib\net40\Moq.dll</HintPath>
Expand Down
9 changes: 4 additions & 5 deletions NLog.Slack.Tests/SlackTargetTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
using System;
using FluentAssertions;
using Microsoft.VisualStudio.TestTools.UnitTesting;

namespace NLog.Slack.Tests
Expand All @@ -12,8 +11,8 @@ public void DefaultSettings_ShouldBeCorrect()
{
var slackTarget = new TestableSlackTarget();

slackTarget.Compact.Should().Be(false);
slackTarget.WebHookUrl.Should().Be(null);
Assert.IsFalse(slackTarget.Compact);
Assert.IsNull(slackTarget.WebHookUrl);
}

[TestMethod]
Expand All @@ -30,8 +29,8 @@ public void CustomSettings_ShouldBeCorrect()

var logEvent = new LogEventInfo { Level = LogLevel.Info, Message = "This is a ${level} message" };

slackTarget.Compact.Should().Be(compact);
slackTarget.WebHookUrl.Should().Be(webHookUrl);
Assert.AreEqual(slackTarget.Compact, compact);
Assert.AreEqual(slackTarget.WebHookUrl, webHookUrl);
}

[TestMethod, ExpectedException(typeof(ArgumentOutOfRangeException))]
Expand Down
1 change: 0 additions & 1 deletion NLog.Slack.Tests/packages.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<packages>
<package id="FluentAssertions" version="3.1.229" targetFramework="net45" />
<package id="Moq" version="4.2.1408.0717" targetFramework="net45" />
<package id="NLog" version="4.5.0" targetFramework="net45" />
</packages>
Loading