feat: add custodialWalletMode to tx senders (Fireblocks)#2172
Open
drift-internal-ai-bot[bot] wants to merge 1 commit intomasterfrom
Open
feat: add custodialWalletMode to tx senders (Fireblocks)#2172drift-internal-ai-bot[bot] wants to merge 1 commit intomasterfrom
drift-internal-ai-bot[bot] wants to merge 1 commit intomasterfrom
Conversation
Custodial wallets like Fireblocks use durable nonces and have longer signing flows. The default 35s timeout is too aggressive for these wallets. This adds a custodialWalletMode option that: - Extends timeout from 35s to 3 minutes - Disables throwOnTimeoutError by default (tx may still land) Applied to BaseTxSender, WhileValidTxSender, RetryTxSender, and ForwardOnlyTxSender. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Fireblocks replaces recentBlockhash with durable nonces and their signing flow (multi-sig, policy checks) can take minutes. The current 35s timeout causes false failures for these users. This mode is activated by the UI when a Fireblocks wallet is detected via WalletConnect.
Relates to BE-256
Test plan