This repository was archived by the owner on Oct 6, 2022. It is now read-only.
Add support for an environ (V2) endpoint #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Is there a status on this? I just set up this runner for one of my deployments thinking |
hwittenborn
added a commit
to makedeb/mprweb
that referenced
this pull request
Mar 30, 2022
Looks like Drone Exec runners don't support variables from environment extensions (from which we relied upon). See drone-runners/drone-runner-exec#5.
hwittenborn
added a commit
to makedeb/mprweb
that referenced
this pull request
Mar 30, 2022
Looks like Drone Exec runners don't support variables from environment extensions (from which we relied upon). See drone-runners/drone-runner-exec#5.
|
@bradrydzewski @mach6: Any status on this? Not sure what needs to happen for this to get merged |
Author
Hi @hwittenborn - I'm waiting to hear back also |
mach6
force-pushed
the
mach6_env_extension
branch
from
a609406 to
d3ad422
Compare
Add the ability to configure a DRONE_ENV_PLUGIN_ENDPOINT with the runner Bump drone-go to v1.6.0 Bump runner-go to 1.7.0 tidy via `go mod tidy`
mach6
force-pushed
the
mach6_env_extension
branch
from
d3ad422 to
a486f32
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to configure a
DRONE_ENV_PLUGIN_ENDPOINT with the runner
Bump drone-go to v1.6.0
Bump runner-go to 1.7.0
tidy via
go mod tidyOpen proposal for this change: drone/proposal#22
Tested on
linux-amd64. All changes were modeled after the current code indrone-runner-docker.I could use some help verifying the changes on these platforms, which I do not have access to.