Restore Convex.jl's tests#107
Open
ericphanson wants to merge 3 commits into
Open
Conversation
ericphanson
commented
Nov 15, 2021
| # Check That Tulip.version() matches what's in the Project.toml | ||
| tlp_ver = Tulip.version() | ||
| toml_ver = TOML.parsefile("../Project.toml")["version"] | ||
| toml_ver = TOML.parsefile(joinpath(@__DIR__, "Project.toml"))["version"] |
Author
There was a problem hiding this comment.
this is an unrelated fix; .. is relative to the working directory, while @__DIR__ is the (absolute path of the) directory of the file itself, so I think this should be more reliable (e.g. it let me do include("test/runtest.jl") without having to switch to the test directory). Let me know if this is undesired and I can undo it.
edit: oops, forgot .., added it in the next commit
Author
|
btw, locally I get |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convex.jl v0.14.17+ supports both MOI v0.9 and v0.10, so these can be restored. (taken out in #105)