fixes: user and webmail auth flow #203
Open
asutoshranjan wants to merge 2 commits intodscnitrourkela:mainfrom
Open
fixes: user and webmail auth flow #203asutoshranjan wants to merge 2 commits intodscnitrourkela:mainfrom
asutoshranjan wants to merge 2 commits intodscnitrourkela:mainfrom
Conversation
asutoshranjan
changed the title
SriramPatibanda
requested changes
Mar 15, 2023
| 'Fest Registration', | ||
| style: interTextTheme.headline2, | ||
| 'Register with a Mobile Number', | ||
| style: interTextTheme.headline2!.copyWith(fontSize: SizeConfig.screenWidth! * 0.058), |
Member
There was a problem hiding this comment.
removing the code is better than commenting on it unless you think it might be used again in the future. I think you can remove the entire section.
| mode: ToastMode.Error, | ||
| title: error, | ||
| ); | ||
| if(error.contains("Unique constraint failed on the constraint: `User_mobile_key`") && error.contains("Invalid `prisma.user.create()`")) { |
Member
There was a problem hiding this comment.
I'm a bit skeptical about this. Ideally you shouldn't use strings for performing checks, backend must send a well-formatted error response. Try to get it changed from the backend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes for #197