Bugfix #3095 develop ascii2nc_tab_delimited #3102
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Differences
These changes include fixes to address issues raised in two discussions:
NaN
inputsThey include:
Update the
is_eq()
logic inis_bad_data.h
to return true if both inputs are bad data, andNaN
is already included in the existing logic for determining bad data.Update
iabp_handler.cc
to use already parsed line of data rather than re-parsing based on spaces (and not including tabs). Also switches a couple==
equality tests for floating point numbers to use theis_eq()
function instead.Add a new ascii2nc unit test with tab-delimited input.
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Describe testing already performed for these changes:
Manually tested to confirm ascii2nc now works as expected with tab-delimited inputs and
NaN
level equality works as expected.Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Ensure the only GHA testing diffs are due to the new ascii2nc output file.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
None neded.
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the MET test suite? [Yes]
If yes, describe the new output and/or changes to the existing output:
Adds 1 new ascii2nc output file.
Will this PR result in changes to existing METplus Use Cases? [No]
If yes, create a new Update Truth METplus issue to describe them.
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
The overall number of code smells remain unchanged at 17,485.
Please complete this pull request review by [Wed 3/12/25].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases