bugfix: fix flakiness in apple music adapter test; by design, it was …

…1/100 chance we would get a failure (#1412)
dtinit · Dec 10, 2024 · 4716397 · 4716397
1 parent 20d5913
commit 4716397
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/...rc/test/java/org/datatransferproject/datatransfer/apple/music/AppleMusicImporterTest.java b/...rc/test/java/org/datatransferproject/datatransfer/apple/music/AppleMusicImporterTest.java
@@ -119,8 +119,8 @@ private AppleMusicInterface setupMusicInterface() throws Exception {
 
     @Test
     public void importPlaylists() throws Exception {
-
         List<MusicPlaylist> musicPlaylists = createTestMusicPlaylists();
+        assertThat(musicPlaylists).isNotEmpty(); // ensure this test actually runs
         setUpImportPlaylistsBatchResponse(musicPlaylists.stream().collect(
                 Collectors.toMap(MusicPlaylist::getId, playlist -> SC_OK)));
 
@@ -186,6 +186,7 @@ private void setUpImportPlaylistsBatchResponse(@Nonnull final Map<String, Intege
     @Test
     public void testImportPlaylistTracks() throws Exception {
         List<MusicPlaylistItem> musicPlaylistItems = createTestPlaylistItems(randomString());
+        assertThat(musicPlaylistItems).isNotEmpty(); // ensure this test actually runs
         setUpImportPlaylistTracksBatchResponse(musicPlaylistItems.stream().collect(
                 Collectors.toMap(item -> item.getTrack().getIsrcCode(), item -> SC_OK)));
 
@@ -269,7 +270,7 @@ private void setUpImportPlaylistTracksBatchResponse(@Nonnull final Map<String, I
     }
 
     private List<MusicPlaylist> createTestMusicPlaylists() {
-        int numMusicPlaylist = RandomUtils.nextInt(0, 100);
+        int numMusicPlaylist = RandomUtils.nextInt(1 /*inclusive*/, 100 /*exclusive*/);
         List<MusicPlaylist> musicPlaylists = new ArrayList<>();
 
         for (int i = 0; i < numMusicPlaylist; i++) {
@@ -290,7 +291,7 @@ private MusicPlaylist createTestMusicPlaylist() {
     }
 
     private List<MusicPlaylistItem> createTestPlaylistItems(String playlistId) {
-        int numMusicPlaylistItem = RandomUtils.nextInt(0, 100);
+        int numMusicPlaylistItem = RandomUtils.nextInt(1 /*inclusive*/, 100 /*exclusive*/);
         List<MusicPlaylistItem> musicPlaylistItems = new ArrayList<>();
 
         for (int i = 0; i < numMusicPlaylistItem; i++) {