Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: release to maven on merge #1423

Merged
merged 6 commits into from
Feb 5, 2025

Conversation

calumcalder
Copy link
Collaborator

Creates a new github action pipeline that runs on merge to master. The pipeline will:

  1. Create a new commit with an updated CHANGELOG.md
  2. Tag that commit and push it to master
  3. Make a clean checkout of that commit
  4. Build, sign, and release all java artefacts to maven

Depends on #1422 to set up the secrets in github

@calumcalder calumcalder requested review from jzacsh and lisad January 9, 2025 11:24
@calumcalder calumcalder mentioned this pull request Jan 9, 2025
Copy link
Collaborator

@jzacsh jzacsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good (obviously pending the secrets as you said). left you a question on the YAML startswith.

@calumcalder calumcalder requested a review from jzacsh January 15, 2025 11:55
jzacsh
jzacsh previously approved these changes Jan 22, 2025
Copy link
Collaborator

@jzacsh jzacsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this is still in draft, but LGTM already. (despite our one basically-resolved comment thread on docs)

@calumcalder calumcalder marked this pull request as ready for review February 3, 2025 17:22
@calumcalder calumcalder requested a review from jzacsh February 4, 2025 11:46
@calumcalder
Copy link
Collaborator Author

Rebased

@calumcalder calumcalder merged commit ade2893 into dtinit:master Feb 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants