ci: release without committing to main branch #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Committing to the master branch isn't allowed from github actions because of our branch protection rules. There's no easy way to allow github actions to bypass this. As a workaround, skip all the parts of the release that needed to commit to the repo. This means moving the version config to an environment variable, which shouldn't be an issue.
calumcalder
force-pushed
the
fix/ci-no-commit
branch
from
af75b87 to
cd229d2
Compare
jzacsh
requested changes
Feb 14, 2025
Co-authored-by: Jonathan Zacsh <[email protected]>
calumcalder
force-pushed
the
fix/ci-no-commit
branch
from
576c3d7 to
cc4c986
Compare
Co-authored-by: Jonathan Zacsh <[email protected]>
calumcalder
force-pushed
the
fix/ci-no-commit
branch
from
cc4c986 to
1996285
Compare
|
Thanks for the suggestions! Applied them all |
jzacsh
reviewed
Feb 18, 2025
jzacsh
previously approved these changes
Feb 18, 2025
jzacsh
approved these changes
Feb 18, 2025
|
Hey @calumcalder if I understand this latest tag correctly, then it:
Is that kind of bump what we want? Or would we expect just a patch bump for a commit like this? (ie: do we want it to have done - NEW_VERSION=$(cz bump --get-next) || exit 1
+ NEW_VERSION=$(cz bump --get-next --increment-mode PATCH) || exit 1 |
|
@jzacsh The bump from 1.0.4 to 1.1.0 was intentional - it calculates it from the difference between HEAD and the previous tag, and there have been a lot of commits between v1.0.4 and now, including some |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committing to the master branch isn't allowed from github actions because of our branch protection rules. There's no easy way to allow github actions to bypass this.
As a workaround, skip all the parts of the release that needed to commit to the repo. This means moving the version config to an environment variable, which shouldn't be an issue, and using git tags as the source of truth.