Fix: Adding Comments to Partner Network Partners throws error#3977
Fix: Adding Comments to Partner Network Partners throws error#3977general-adhoc wants to merge 1 commit into
Conversation
…r + minor DRY refactor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughA new helper consolidates partner reachability into ChangesPartner Reachability Logic Consolidation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai full review |
✅ Action performedFull review finished. |
|
@coderabbitai full review please |
|
🧠 Learnings used✅ Action performedFull review finished. |
Bug: if a Program attempts to add a comment to a Partner while browsing the Partner Network, the backend rejects this comment and the UI throws an error because the Add Comment API requires program enrollment.
This functionality would be useful to Program teams evaluating partners/strategizing on outreach and should be allowed. If this behavior is intentional - fix would be to instead remove the add comment panel.
This PR updates the create partner comment API to allow this, as well as a light refactor to avoid duplicate query code in several places.
Before:
After:
Summary by CodeRabbit