Open
Conversation
Find sudo wherever in PATH it may be.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Find sudo wherever it may be.
I allocated memory, is that ok?
In my commit, on line 197, the compiler complained about possibly truncating a string, so I used a larger buffer(PATH_MAX) for
command.And when finding the first sudo in PATH, I just ignore the first path, since it should be the one the attacker has added. I think it should be correct? Because of this,
hunter@nsa:~$ ./sudo whoamiline in README.md might not work if there's only one sudo in the PATH.