Open
Conversation
…nster/duckdb-iceberg into schema_change_support_iceberg_tables
…upport_iceberg_tables
…upport_iceberg_tables
…rt_iceberg_tables
…rt_iceberg_tables
Tishj
reviewed
Feb 8, 2026
|
|
||
| void IcebergPartitionSpec::FieldsToJson(yyjson_mut_doc *doc, yyjson_mut_val *root_object, | ||
| const vector<rest_api_objects::PartitionField> &fields) { | ||
| yyjson_mut_obj_add_strcpy(doc, root_object, "type", "struct"); |
Collaborator
There was a problem hiding this comment.
I don't know where this is in the spec
I feel like we're building this object, no?
PartitionSpec:
type: object
required:
- fields
properties:
spec-id:
type: integer
readOnly: true
fields:
type: array
items:
$ref: '#/components/schemas/PartitionField'This should only have spec-id and fields if that's the case?
We already added spec-id earlier:
yyjson_mut_obj_add_int(doc, spec_json, "spec-id", ref_update.spec.spec_id);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports partition defintions (not inserts)
You can define a partition definition in either the
CREATE TABLEstatement, or in theALTER TABLEstatement.