Skip to content

Fix select_dtypes for quoted column identifiers #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evertlammerts merged 6 commits into from
Jan 5, 2026
Merged

Fix select_dtypes for quoted column identifiers #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c9fb976
Fix select_dtypes with quoted identifiers
Schwarf Dec 31, 2025
0ed560a
Add test to verify bug is fixed.
Schwarf Jan 1, 2026
1440722
ci: trigger
Schwarf Jan 1, 2026
75181a2
Add new line at EOF.
Schwarf Jan 1, 2026
b690066
Merge branch 'main' into fix/select-dtypes-identifier-quoting
evertlammerts Jan 5, 2026
ff32a8a
Fix review finding. Use KeywordHelper::WriteOptionallyQuoted
Schwarf Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/duckdb_py/pyrelation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ unique_ptr<DuckDBPyRelation> DuckDBPyRelation::ProjectFromTypes(const py::object
if (!projection.empty()) {
projection += ", ";
}
projection += names[i];
projection += KeywordHelper::WriteOptionallyQuoted(names[i]);
}
}
if (projection.empty()) {
Expand Down
7 changes: 7 additions & 0 deletions tests/fast/test_relation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,3 +688,10 @@ def create_view(con, view_name: str) -> None:

res = con.sql("select * from vw").fetchall()
assert res == expected

def test_relation_select_dtypes_quotes_identifiers_with_spaces(self, duckdb_cursor):
df = pd.DataFrame({"na me": ["alice", "bob"], "x": [1, 2]})
rel = duckdb_cursor.from_df(df)
out = rel.select_dtypes([duckdb.sqltypes.VARCHAR]).fetchdf()
assert list(out.columns) == ["na me"]
assert out["na me"].tolist() == ["alice", "bob"]