Skip to content

Windows Ninja Builds - faster build times #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Windows Ninja Builds - faster build times #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions .github/workflows/packaging_wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,14 +89,26 @@ jobs:
cache-suffix: -${{ matrix.python }}-${{ matrix.platform.cibw_system }}_${{ matrix.platform.arch }}
python-version: ${{ matrix.python }}

# Load MSVC environment, needed for Windows - ninja builds
# Without this, the linking step will fail.
# Note: CIBW uses the host environment for windows, rather than an isolated container
- uses: ilammy/msvc-dev-cmd@v1
if: ${{ matrix.platform.cibw_system == 'win' }}
with:
arch: ${{ matrix.platform.arch }}

- name: Build${{ inputs.testsuite != 'none' && ' and test ' || ' ' }}wheels
uses: pypa/[email protected]
env:
CIBW_ARCHS: ${{ matrix.platform.arch == 'amd64' && 'AMD64' || matrix.platform.arch }}
CIBW_BUILD: ${{ matrix.python }}-${{ matrix.platform.cibw_system }}_${{ matrix.platform.arch }}
# PYTHON_GIL=1: Suppresses the RuntimeWarning that the GIL is enabled on free-threaded builds.
# TODO: Remove PYTHON_GIL=1 when free-threaded is supported.
# PYTHON_GIL=1: Suppresses the RuntimeWarning that the GIL is enabled on free-threaded builds.
# TODO: Remove PYTHON_GIL=1 when free-threaded is supported.
# CMAKE_BUILD_TYPE=Release: Override Debug default when MSVC dev environment is loaded
CIBW_ENVIRONMENT: PYTHON_GIL=1
# For Windows, msvc-dev-cmd sets build to Debug. So, override it back to Release.
# This is a problem because Debug enables Jemalloc, which fails to build on Windows
CIBW_ENVIRONMENT_WINDOWS: PYTHON_GIL=1 CMAKE_BUILD_TYPE=Release
- name: Upload wheel
uses: actions/upload-artifact@v4
with:
Expand Down
10 changes: 9 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,13 @@ if.env.COVERAGE = false
inherit.cmake.define = "append"
cmake.define.DISABLE_UNITY = "1"

[[tool.scikit-build.overrides]]
if.platform-system = "^win32"
cmake.args = [
"-G", "Ninja",
"--log-level=DEBUG",
]

[tool.scikit-build.sdist]
include = [
"README.md",
Expand Down Expand Up @@ -388,4 +395,5 @@ before-build = ["yum install -y ccache"]
before-build = ["brew install ccache"]

[tool.cibuildwheel.windows]
before-build = ["choco install ccache"]
# Strawberry ccache is already installed on the cibuildwheel images
before-build = []