Add ST_ClipByRect #665
Open
Add ST_ClipByRect #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This currently falls back to a GEOS implementation for anything more complex than points.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently falls back to a GEOS implementation for anything more complex than points. I had originally intended to do the linestring implementation too, but it became ugly.
This is a step in the implementation for the MVT geometry conversion, but wanted to avoid that getting too complicated, and it seems like useful functionality as a standalone function.
I'm not especially happy with the "GeosOperations" bridge code, but unsure of a better way. Would definitely appreciate review comments on that.