Remove FeatureExceptions.Store and all its implementations #5877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
aitorvs
force-pushed
the
feature/aitor/ff/removeExceptionStores
branch
from
7c723e7 to
243fb2f
Compare
aitorvs
force-pushed
the
feature/aitor/ff/removeExceptionStores
branch
4 times, most recently
from
8011d5c to
9b2da35
Compare
aitorvs
force-pushed
the
feature/aitor/ff/removeExceptionStores
branch
from
9b2da35 to
42a7c06
Compare
aitorvs
force-pushed
the
feature/aitor/ff/removeExceptionStores
branch
from
42a7c06 to
9d76104
Compare
aitorvs
force-pushed
the
feature/aitor/ff/removeExceptionStores
branch
from
9d76104 to
d8d9307
Compare
CDRussell
approved these changes
May 8, 2025
CDRussell
approved these changes
May 8, 2025
Task/Issue URL: ### Description Stacked onto #5877. Use this one for testing. FeatureExceptions.Store interface as it's no longer necessary after adding getExceptions() We'll need to remove the following classes * AutoconsentExceptionsStore * AutofillServiceExceptionsStore * MediaPlaybackStore * DrmBlockFeatureExceptionStore * MaliciousSiteProtectionExceptionsStore * AutofillSiteBreakageReportingExceptionsPersister * AutofillFeatureExceptionStore * EmailProtectionInContextRemoteExceptionsPersister We'll need to refactor repositories associated to classes above ### Steps to test this PR Smoke test all features related to the stores above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1202552961248957/1209892744822628/f
Description
FeatureExceptions.Store interface as it's no longer necessary after adding getExceptions()
We'll need to remove the following classes
We'll need to refactor repositories associated to classes above
Steps to test this PR
Smoke test all features related to the stores above