SenseOfProtection experiment: Cohort survey param #5889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikescamell
force-pushed
the
feature/mike/sense-of-protection-test/add-test-framework
branch
from
a75ac5d to
2cff60a
Compare
mikescamell
force-pushed
the
feature/mike/sense-of-protection-test/add-test-framework
branch
from
2cff60a to
cb2d266
Compare
nalcalag
force-pushed
the
feature/noelia/add_cohort_survey_param
branch
from
df7c527 to
0736cf4
Compare
nalcalag
merged commit 66eb683
into
feature/mike/sense-of-protection-test/add-test-framework
1 of 4 checks passed
cmonfortep
reviewed
Apr 16, 2025
| ) : SurveyParameterPlugin { | ||
| override val surveyParamKey: String = "senseProtectionCohort" | ||
|
|
||
| override suspend fun evaluate(): String = senseOfProtectionToggles.senseOfProtectionNewUserExperimentApr25().getCohort()?.name.orEmpty() |
There was a problem hiding this comment.
@nalcalag shouldn't we checking that experiment is active?
There was a problem hiding this comment.
If we check if the experiment is active, a cohort will be assigned and we don't want that. We created a new survey for the experiment, so as soon as the experiment is disabled, we should also disable the survey or remove this survey param if they want to keep it.
malmstein
pushed a commit
that referenced
this pull request
Apr 25, 2025
Task/Issue URL: https://app.asana.com/0/1202552961248957/1209874180233369/f Added a temporary survey param for experiment cohort - N/A --------- Co-authored-by: Mike Scamell <[email protected]>
malmstein
pushed a commit
that referenced
this pull request
Apr 28, 2025
Task/Issue URL: https://app.asana.com/0/1202552961248957/1209874180233369/f Added a temporary survey param for experiment cohort - N/A --------- Co-authored-by: Mike Scamell <[email protected]>
malmstein
pushed a commit
that referenced
this pull request
Apr 28, 2025
Task/Issue URL: https://app.asana.com/0/1202552961248957/1209874180233369/f Added a temporary survey param for experiment cohort - N/A --------- Co-authored-by: Mike Scamell <[email protected]>
malmstein
pushed a commit
that referenced
this pull request
Apr 29, 2025
Task/Issue URL: https://app.asana.com/0/1202552961248957/1209874180233369/f Added a temporary survey param for experiment cohort - N/A --------- Co-authored-by: Mike Scamell <[email protected]>
malmstein
pushed a commit
that referenced
this pull request
Apr 30, 2025
Task/Issue URL: https://app.asana.com/0/1202552961248957/1209874180233369/f Added a temporary survey param for experiment cohort - N/A --------- Co-authored-by: Mike Scamell <[email protected]>
malmstein
pushed a commit
that referenced
this pull request
Apr 30, 2025
Task/Issue URL: https://app.asana.com/0/1202552961248957/1209874180233369/f Added a temporary survey param for experiment cohort - N/A --------- Co-authored-by: Mike Scamell <[email protected]>
malmstein
pushed a commit
that referenced
this pull request
Apr 30, 2025
Task/Issue URL: https://app.asana.com/0/1202552961248957/1209874180233369/f Added a temporary survey param for experiment cohort - N/A --------- Co-authored-by: Mike Scamell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1202552961248957/1209874180233369/f
Description
Added a temporary survey param for experiment cohort
Steps to test this PR
No UI changes