Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/Modules/Id3v2.php
Original file line number Diff line number Diff line change
Expand Up @@ -160,18 +160,16 @@ private function parseItem(&$frames)

switch ($encoding) {
case self::HAS_BOM:
$value = Bom::removeBom($value);
break;
case self::UTF_16:
$value = "\xFE\xFF" . $value;
break;
case self::UTF_8:
break;
default:
$value = utf8_encode($value);
}

$value = Bom::removeBom($value);

# Strings are unreliably terminated with nulls, so just strip any that are present
$value = rtrim($value, "\0");

Expand Down
7 changes: 7 additions & 0 deletions tests/Modules/Id3v2Test.php
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,13 @@ public function testUtf16WithBom()
$module = $this->getEncoded();
assertSame("To Speak, to Listen", $module->getAlbum());
}
public function testWin1251()
{
$file = new File(__DIR__ . "/../data/cp1251.mp3");
$module = new Id3v2();
$module->open($file);
assertSame("Аквариум", iconv("cp1251", "utf-8", $module->getArtist()));
}
public function testUtf16WithoutBom()
{
$module = $this->getEncoded();
Expand Down
Binary file added tests/data/cp1251.mp3
Binary file not shown.